[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE", Twine(WavefrontSize)); + Builder.defineMacro("__AMDGCN_CUMODE", Twine(CUMode)); } arsenm wrote: > Why do we sometimes use __ on bo

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE", Twine(WavefrontSize)); + Builder.defineMacro("__AMDGCN_CUMODE", Twine(CUMode)); } Why do we sometimes use __ on both sides, and so

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

yaxunl added a comment. In D145343#4172643 , @tra wrote: > Can `__has_feature` be used to accomplish what you need? There are a few issues using `__has_feature` or similar builtin macros to check target feature, which has been discussed in https://revie

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

yaxunl updated this revision to Diff 518391. yaxunl retitled this revision from "[AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`" to "[AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added subscribers: llvm-commit