[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. In D145302#4492595 , @mstorsjo wrote: > In D145302#4491973 , @glandium > wrote: > >> This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: > > I also ran into this; I pushed a fix in

[PATCH] D145302: [clangd] Add library for clangd main function

mstorsjo added a comment. In D145302#4491973 , @glandium wrote: > This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: I also ran into this; I pushed a fix in a20d57e83441a69fa2bab86593b18cc0402095d2

[PATCH] D145302: [clangd] Add library for clangd main function

raj.khem added a comment. indeed, broke my CI with same issue. In D145302#4491973 , @glandium wrote: > This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: > > /usr/bin/ld: > tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTw

[PATCH] D145302: [clangd] Add library for clangd main function

glandium added a comment. This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: /usr/bin/ld: tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/AddUsing.cpp.o: in function `clang::clangd::(anonymous namespace)::AddUsing::prepare(clang::clangd::Tweak::Selectio

[PATCH] D145302: [clangd] Add library for clangd main function

This revision was automatically updated to reflect the committed changes. Closed by commit rG56ac9d46a7c1: [clangd] Add library for clangd main function (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://re

[PATCH] D145302: [clangd] Add library for clangd main function

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 _

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 539119. ivanmurashko added a comment. rebase before the final push Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/tool/CMakeLi

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. In D145302#4441334 , @kadircet wrote: > thanks LG and seems to be working in a couple build configurations I tried. > but there might still be breakages in different configs, so please be on the > watchout after landing thi

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/tool/CMakeLists.txt:37 + +target_link_libraries(clangdMain + PRIVATE kadircet wrote: > you can merge this with the previous rule fixed Comment at: clang-tools-extra/clang

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko marked an inline comment as not done. ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/tool/CMakeLists.txt:11 + ClangdToolMain.cpp $ ) kadircet wrote: > we should move this into `clangdMain` target now Unfortunately it

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 536577. ivanmurashko added a comment. Fixed clangd unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/tool/CMakeLists.t

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 535144. ivanmurashko added a comment. small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/tool/CMakeLists.txt clang-t

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 535138. ivanmurashko added a comment. Rebase + apply suggestions from @kadircet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd

[PATCH] D145302: [clangd] Add library for clangd main function

kadircet added a comment. thanks LG and seems to be working in a couple build configurations I tried. but there might still be breakages in different configs, so please be on the watchout after landing this for breakages in https://lab.llvm.org/. FWIW something like: # Needed by LLVM's CMake

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 525570. ivanmurashko added a comment. removed header install, only lib install has been left after the change CC: @kadircet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.o

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 525558. ivanmurashko added a comment. rebased to the latest LLVM main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/CMakeList

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. > Can this be solved at the build-system level, without changing the source > code in ways that aren't otherwise useful? > For example, with a `CLANG_TIDY_EXTRA_CHECKS` cmake variable that adds more > deps? This seems like it could also work for the `clang-tidy` bin

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 507029. ivanmurashko added a comment. The change addresses comments from D145228 . The only one header is copied as a part of the installation. As result the diff contains the minimal changes required to integrated clan

[PATCH] D145302: [clangd] Add library for clangd main function

sammccall added a comment. IIUC we want to link some extra targets into the `clangd` binary in order to provide extra clang-tidy checks, but *don't* want to customize the binary further. (The latter can be useful, but this interface isn't sufficient for it). Can this be solved at the build-syst

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, kadircet, ilya-biryukov. Herald added a subscriber: arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools