[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

2023-03-10 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `computeTargetTriple` has several users. You probably want to check all these code paths do not need `if (const Arg *A = Args.getLastArg(options::OPT_target))`. For the uses in `BuildCompila

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

2023-03-09 Thread WangLian via Phabricator via cfe-commits
Jimerlife added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145146/new/ https://reviews.llvm.org/D145146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

2023-03-02 Thread WangLian via Phabricator via cfe-commits
Jimerlife created this revision. Jimerlife added reviewers: phosek, kazu, abrachet. Jimerlife added a project: LLVM. Herald added a project: All. Jimerlife requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskRay. Herald added a project: clang. `options::OPT_t