Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-10 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Committed in r252601. http://reviews.llvm.org/D14502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Chris Bieneman via cfe-commits
> On Nov 9, 2015, at 2:07 PM, Aaron Ballman wrote: > > aaron.ballman added inline comments. > > > Comment at: tools/driver/CMakeLists.txt:58 > @@ -62,1 +57,3 @@ > > +if(NOT MSVC) > + add_custom_target(install-clang > > beanz wrote: >> Can you change this to `

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: tools/driver/CMakeLists.txt:58 @@ -62,1 +57,3 @@ +if(NOT MSVC) + add_custom_target(install-clang beanz wrote: > Can you change this to `if(NOT CMAKE_CONFIGURATION_TYPES)`? > > With that it won't create the insta

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Chris Bieneman via cfe-commits
beanz accepted this revision. This revision is now accepted and ready to land. Comment at: tools/driver/CMakeLists.txt:58 @@ -62,1 +57,3 @@ +if(NOT MSVC) + add_custom_target(install-clang Can you change this to `if(NOT CMAKE_CONFIGURATION_TYPES)`? With that it

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Ben Craig via cfe-commits
bcraig added a comment. In a text file, I have a big long cmake invocation. Part of that invocation is the following: -DCMAKE_INSTALL_PREFIX=c:/install/Tools The VC "INSTALL" project copies files there, in a very unix-y hierarchy (i.e. c:\install\Tools\bin, c:\install\Tools\include, c:\inst

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D14502#285371, @aaron.ballman wrote: > In http://reviews.llvm.org/D14502#285305, @bcraig wrote: > > > Does this affect the presence or functionality of the "INSTALL" project? > > > There is no INSTALL project in MSVC from what I can see (b

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D14502#285305, @bcraig wrote: > Does this affect the presence or functionality of the "INSTALL" project? There is no INSTALL project in MSVC from what I can see (before or after this patch), so I don't think that this affects that funct

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Ben Craig via cfe-commits
bcraig added a subscriber: bcraig. bcraig added a comment. Does this affect the presence or functionality of the "INSTALL" project? http://reviews.llvm.org/D14502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added a reviewer: beanz. aaron.ballman added a subscriber: cfe-commits. When generating an MSVC solution from CMake, it creates a clang-install project. We do not have any *-install targets as part of MSVC, so this seems out of place (not to men