[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fbf18b40026: [clang] Fix aggregate initialization inside lambda constexpr (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actually

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actually

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon added a comment. Thanks for the review @shafik . Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actually

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, the modules failures is a previous known issue. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ens

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actua

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon updated this revision to Diff 501084. Fznamznon added a comment. Apply suggestions and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144866/new/ https://reviews.llvm.org/D144866 Files: clang/docs/ReleaseNotes.rst clang/lib/AS

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added a comment. Also please add a release note before landing the fix, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144866/new/ https://reviews.llvm.org/D144866 ___ cfe-commits mailin

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added a comment. Thank you for this patch, it looks good. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Constant evaluator only considered access to `this` pointer to be possible if `this` poitners was captured. However `thi