[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. In D144603#4165569 , @fangism wrote: > In D144603#4163751 , @phosek wrote: > >> In D144603#4162974 , @haowei wrote: >> >>> I think remove the compi

[PATCH] D144603: Add option to disable compiler launcher on external projects

fangism added a comment. In D144603#4163751 , @phosek wrote: > In D144603#4162974 , @haowei wrote: > >> I think remove the compiler launcher from default pass through flags are >> fine. What about the using compi

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. In D144603#4162974 , @haowei wrote: > I think remove the compiler launcher from default pass through flags are > fine. What about the using compiler launcher in runtime builds? I don't think > we should read `CLANG_BOOTSTRAP_PASS

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei updated this revision to Diff 501670. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 Files: clang/CMakeLists.txt clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake llvm

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei added a comment. In D144603#4162223 , @phosek wrote: > I agree, in that case let's remove > `C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER` from the list of default > passthrough variables which seems like a reasonable default, and provide > `CLANG_

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. I agree, in that case let's remove `C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER` from the list of default passthrough variables which seems like a reasonable default, and provide `CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH` so developers have a way to pass these through to the next

[PATCH] D144603: Add option to disable compiler launcher on external projects

smeenai added a comment. In D144603#4162192 , @haowei wrote: > In D144603#4162048 , @smeenai wrote: > >> Hmm, what cache key does ccache use for compilers? Is it the `--version` >> output string, the path, or som

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei added a comment. In D144603#4162048 , @smeenai wrote: > Hmm, what cache key does ccache use for compilers? Is it the `--version` > output string, the path, or some combination? If the path is involved then I > don't see any value in using ccache

[PATCH] D144603: Add option to disable compiler launcher on external projects

smeenai added a comment. Hmm, what cache key does ccache use for compilers? Is it the `--version` output string, the path, or some combination? If the path is involved then I don't see any value in using ccache for configuring anything past stage1, since the compiler will (presumably) be instal

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. @beanz @smeenai do you have any preferences/other ideas? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 ___ cfe-commits mailing list cf

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. A more generic version might be to have a list of variables to (not) passthrough. First option is to remove `{C,CXX}_COMPILER_LAUNCHER` from `_BOOTSTRAP_DEFAULT_PASSTHROUGH` and then include it as needed by setting something like `CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH=C_CO

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When using compiler caching program li