[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

owenpan added a comment. In D144537#4152225 , @rymiel wrote: > In D144537#4145545 , > @MyDeveloperDay wrote: > >> maybe we should cherry pick into 16? > > I don't know how to do backports and I don't want to mess

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393e197cd6eb: [clang-format] Don't move qualifiers past pointers-to-member (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

rymiel added a comment. In D144537#4145545 , @MyDeveloperDay wrote: > maybe we should cherry pick into 16? It's up to one of you (mostly because I don't know how to do backports and I don't want to mess it up) Repository: rG LLVM Github Monorepo C

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D144537#4145545 , @MyDeveloperDay wrote: > maybe we should cherry pick into 16? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

MyDeveloperDay added a comment. maybe we should cherry pick into 16? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144537/new/ https://reviews.llvm.org/D144537 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thanks for doing this @rymiel, LGTM.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144537/new/ https://reviews.llvm.org/D144537 ___

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:284-285 +// However, `const Bar::*` remains the same. +while (Next && Next->isOneOf(tok::identifier, t

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, given a