[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-13 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Thanks, sent a patch to gdb at https://sourceware.org/pipermail/gdb-patches/2023-April/198870.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-13 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added a comment. > It adds an include of #include <__format/formatter_integral.h> which ends up > including which has internal definitions of isupper/islower causing > clang to complain. > > Any suggestions on what would be the right fix here? It sounds like `safe-ctype.h` should a

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-13 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Hmm, looking deeper, gdb (actually binutils), is doing something weird. https://github.com/bminor/binutils-gdb/blob/master/include/safe-ctype.h /* Prevent the users of safe-ctype.h from accidently using the routines from ctype.h. Initially, the approach was to

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-13 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added subscribers: cor3ntin, tahonermann. tahonermann added a comment. Adding Corentin for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 __

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-12 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. I have opened a bug at issuetracker.google.com/issues/277967395 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 ___ cfe-commits mail

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-12 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Just a heads up, with this change, we are hitting issues in building gdb. Appreciate any ideas on what is wrong. aarch64-cros-linux-gnu-clang++ -x c++-I. -I. -I./config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I../bfd -I./..

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-09 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked an inline comment as done. Mordante added inline comments. Comment at: libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cpp:49 + std::same_as auto it = formatter.parse(parse_ctx); + assert(it == fmt.end() - (!fmt.empty() &&

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-08 Thread Mark de Wever via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88622aabf107: [libc++][format] Implements formatter thread::id. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-08 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 511875. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes.

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-08 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 511865. Mordante added a comment. Herald added a subscriber: krytarowski. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestM

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-07 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 511715. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes.

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-07 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 511709. Mordante added a comment. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-07 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 511705. Mordante marked 2 inline comments as done. Mordante added a comment. Rebased, addresses review comment, and get a CI run. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not cont

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

2023-04-07 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 4 inline comments as done. Mordante added a comment. Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Thanks for the review! Comment at: libcxx/test/