[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

brad added a comment. In D144232#4155966 , @adalava wrote: > I agree with D144321 , sorry for the late > reply. @pkubaj and @brad , thanks for pushing it. I think D144232 > can be aba

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. In D144232#4137367 , @dim wrote: > In D144232#4136787 , @brad wrote: > >> I noticed this review. I have provided a more complete diff for review at >> D144321

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

dim added a comment. In D144232#4136787 , @brad wrote: > I noticed this review. I have provided a more complete diff for review at > D144321 . Yeah I think that is probably the better option, hope @pkubaj and @adalava

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

brad added a comment. I noticed this review. I have provided a more complete diff for review at D144321 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 ___

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj updated this revision to Diff 498378. pkubaj added a comment. Addres adalava's review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 Files: clang/lib/Basic/Targets/PPC.h llvm/lib/Target/Power

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. Nice catch! I'm not a LLVM maintainer but from FreeBSD PowerPC side I agree with the changes, only added two suggestions that could improve code readability Comment at: clang/lib/Basic/Targets/PPC.h:428 ABI = "elfv2"; +} else if (Triple.isO

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj updated this revision to Diff 498185. pkubaj added a comment. Fix indenting according to clang-format suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144232/new/ https://reviews.llvm.org/D144232 Files: clang/lib/Basic/Targets/P

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj created this revision. pkubaj added reviewers: dim, nemanjai, adalava. Herald added subscribers: shchenz, kbarton, hiraditya. Herald added a project: All. pkubaj requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Curre