Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-09 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. r252474 http://reviews.llvm.org/D14403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-09 Thread Jonathan Roelofs via cfe-commits
jroelofs updated this revision to Diff 39693. jroelofs added a comment. Add flags to turn the new targets off. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/CMakeLists.txt tools/scan-build/Makefile tools/scan-build/scan-build tools/scan-v

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-06 Thread Jonathan Roelofs via cfe-commits
jroelofs added a comment. In http://reviews.llvm.org/D14403#284054, @beanz wrote: > I would prefer if installing these were optional and could be toggled on/off. I'll add flags for that. http://reviews.llvm.org/D14403 ___ cfe-commits mailing list

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-06 Thread Ben Craig via cfe-commits
bcraig added a subscriber: bcraig. bcraig added a comment. For what it's worth, our internal branch installs these by default, and I was unpleasantly surprised when I found that upstream didn't. http://reviews.llvm.org/D14403 ___ cfe-commits mailin

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-06 Thread Chris Bieneman via cfe-commits
beanz added a comment. I would prefer if installing these were optional and could be toggled on/off. Other than that this all looks fine to me. http://reviews.llvm.org/D14403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-06 Thread Jonathan Roelofs via cfe-commits
jroelofs updated this revision to Diff 39529. jroelofs added a comment. Forgot to `svn add` after rebasing the patch on top of upstream. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/CMakeLists.txt tools/scan-build/Makefile tools/scan-build

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-05 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: www/analyzer/installation.html:103 @@ -102,3 +102,1 @@ -Currently these are not installed using make install, and -are located in $(SRCDIR)/tools/clang/tools/scan-build and jroelofs wrote: > @zaks.anna Do you know if

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-05 Thread Jonathan Roelofs via cfe-commits
jroelofs added inline comments. Comment at: www/analyzer/installation.html:103 @@ -102,3 +102,1 @@ -Currently these are not installed using make install, and -are located in $(SRCDIR)/tools/clang/tools/scan-build and @zaks.anna Do you know if there was a particu

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-05 Thread Jonathan Roelofs via cfe-commits
jroelofs updated this revision to Diff 39439. jroelofs added a comment. Update www too. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/scan-build tools/scan-view/Reporter.py tools/scan-view/ScanView.py www/analyzer/installation.html Index

[PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-05 Thread Jonathan Roelofs via cfe-commits
jroelofs created this revision. jroelofs added reviewers: zaks.anna, beanz. jroelofs added a subscriber: cfe-commits. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/scan-build tools/scan-view/Reporter.py tools/scan-view/ScanView.py Index: too