[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cc91f977eaa: [Clang] Copy strictfp attribute from pattern to instantiation (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 ___

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824 + continue; +} + efriedma wrote: > sepavloff wrote: > > efriedma wrote: > > > Is this necessary? The non-delayed-parsed case seems to work correctly > > > o

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff updated this revision to Diff 498248. sepavloff added a comment. Remove copying StrictFPAttr from InstantiateAttrs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 Files: clang/include/clang/Se

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824 + continue; +} + sepavloff wrote: > efriedma wrote: > > Is this necessary? The non-delayed-parsed case seems to work correctly on > > trunk without any chang

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. In D143919#4130178 , @efriedma wrote: > If the "strictfp" attribute is based on the contents of the function body, > should we recompute it when the function is instantiated, as opposed to > copying it? For example, say you h

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added a comment. If the "strictfp" attribute is based on the contents of the function body, should we recompute it when the function is instantiated, as opposed to copying it? For example, say you have a pragma inside an "if constexpr"; should that set the strictfp attribute if it's d

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. In D143919#4123922 , @rjmccall wrote: > In D143919#4123712 , @sepavloff > wrote: > >> In D143919#4123616 , @efriedma >> wrote: >> >>> We have

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff updated this revision to Diff 497609. sepavloff added a comment. Changed the way to copy strictfp attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 Files: clang/include/clang/Sema/Sema

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

rjmccall added a comment. In D143919#4123712 , @sepavloff wrote: > In D143919#4123616 , @efriedma > wrote: > >> We have code somewhere to generically copy attributes from function >> templates to instantiations,

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. In D143919#4123616 , @efriedma wrote: > We have code somewhere to generically copy attributes from function templates > to instantiations, right? Why do we need to explicitly copy StrictFPAttr in > particular, separate from t

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added a comment. We have code somewhere to generically copy attributes from function templates to instantiations, right? Why do we need to explicitly copy StrictFPAttr in particular, separate from that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. If a template function contained a pragma that made it strictfp, code generation for such