[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ec6e09abe8: [NFC] [clang] Forward forwarding reference (authored by ccotter, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/n

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. I don't have commit access - could you use `Author: Chris Cotter `? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-co

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Can you commit this yourself, or would you like me to commit it on your behalf? (what name/email address would you like it attributed to?) Repository: rG LLVM Githu

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie added a comment. In D143877#4156769 , @dblaikie wrote: >> Although we may not agree such ideas, we should offer an option for the >> users to give them the right to choose. > > I think @iains was bemoaning the large number of module flags recent

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie added a subscriber: iains. dblaikie added a comment. > Although we may not agree such ideas, we should offer an option for the users > to give them the right to choose. I think @iains was bemoaning the large number of module flags recently - perhaps he'd have some thoughts on this, but

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. @dblaikie thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter updated this revision to Diff 497146. ccotter added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 Files: clang/include/clang/AST/IgnoreExpr.h clang/unittests/AST/ASTExp

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. Realistically, I'm not sure if this change is all that valuable aside from abiding by the CppCoreGuidelines from the readability and consistency standpoint. The only impact this change would have that I can think of is allowing an object with an `&&` (or other combinati

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

dblaikie added a comment. any chance this is testable, maybe in a unit test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list cfe-co

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter created this revision. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update function bodies to forward forwarding references. I spotted this while authoring a clang-tidy tool for CppCoreGuideli