[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan added a comment. @kadircet thanks for reporting the crash and reverting the commit. I will fix it and reland the patch. Comment at: clang/lib/Format/TokenAnnotator.cpp:1229 + consumeToken(); +assert(CurrentToken); +auto Previous = CurrentToken-

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

kadircet added a comment. Hi @owenpan, this seems to be crashing for: struct Foo { operator enum foo{} }; with stack trace: $ ~/repos/llvm/build/bin/clang-format format_crash.cc --dry-run clang-format: /usr/local/google/home/kadircet/repos/llvm/clang/lib/Format/TokenAnnotator.cpp:1229:

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb05dc1b8766a: [clang-format] Add a space between an overloaded operator and '>' (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143755/new/ https://reviews.llvm.org/D143755 ___ cfe-commits mailing li

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan added a comment. In D143755#4118802 , @vedgy wrote: > Hi @owenpan. Thank you for fixing this bug! > Have you noticed this paragraph in my bug report? > >> I believe `clang_getTypeSpelling()`, or more likely `QualType::print()` used >> by it, shou

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan updated this revision to Diff 496670. owenpan added a comment. Added `tryMergeGreaterGreater()` to and fixed `tryMergerLessLess()` of `FormatTokenLexer`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143755/new/ https://reviews.llvm.org/D143755 Files: clang/lib/Format/Format

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

vedgy added a comment. Hi @owenpan. Thank you for fixing this bug! Have you noticed this paragraph in my bug report? > I believe `clang_getTypeSpelling()`, or more likely `QualType::print()` used > by it, should insert a tab character between such tokens to pretty-print > compilable code. The t

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The token annota