[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan marked an inline comment as done. owenpan added a comment. In D143546#4116354 , @MyDeveloperDay wrote: > In D143546#4114341 , @owenpan wrote: > >> In D143546#4113721

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan marked an inline comment as done. owenpan added a comment. In D143546#4116196 , @HazardyKnusperkeks wrote: > In D143546#4114341 , @owenpan wrote: > >> In D143546#4113721

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4e35c63711b: [clang-format] Insert a space between a numeric UDL and a dot (authored by owenpan). Changed prior to commit: https://reviews.llvm.o

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

MyDeveloperDay added a comment. In D143546#4114341 , @owenpan wrote: > In D143546#4113721 , @rymiel wrote: > >> In D143546#4112077 , @owenpan >> wrote: >> >>> As this one

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143546/new/ https://reviews.llvm.org/D143546 ___ cfe-commits mailing list cfe-com

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

HazardyKnusperkeks added a comment. In D143546#4114341 , @owenpan wrote: > In D143546#4113721 , @rymiel wrote: > >> In D143546#4112077 , @owenpan >> wrote: >> >>> As this

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan added a comment. In D143546#4113721 , @rymiel wrote: > In D143546#4112077 , @owenpan wrote: > >> As this one is an invalid-code-generation bug, I wanted it fixed ASAP. > > Do you intend to backport it to t

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan added a comment. In D143546#4113730 , @rsmith wrote: > I wonder if this can be fixed more generally by using > `TokenConcatenation::AvoidConcat` to determine whether `clang-format` should > require a space between two tokens. Probabtly not as c

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rsmith added a comment. I wonder if this can be fixed more generally by using `TokenConcatenation::AvoidConcat` to determine whether `clang-format` should require a space between two tokens. This is the logic that `clang -E` uses when printing preprocessed tokens to avoid token splices. For exa

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rymiel added a comment. In D143546#4112077 , @owenpan wrote: > As this one is an invalid-code-generation bug, I wanted it fixed ASAP. Do you intend to backport it to the 16 release branch then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3884 if (Style.isCpp()) { +if (Right.is(tok::period) && Left.is(tok::numeric_constant)) + return true; HazardyKnusperkeks wrote: > Add a comment what that is? Without the b

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3884 if (Style.isCpp()) { +if (Right.is(tok::period) && Left.is(tok::numeric_constant)) + return true; Add a comment w

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan added a comment. In D143546#4111827 , @rymiel wrote: > I've been sniped! (but only because i spent hours discussing with people if > the error is pedantically valid, which it turns out it is) I was wondering why you didn't assign yourself. :) Wh

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I've been sniped! (but only because i spent hours discussing with people if the error is pedantically valid, which it turns out it is) Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://gi