[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc812ab731243: [include-mapping] Add C-compatibility symbol entries. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet accepted this revision. kadircet added a comment. thanks, lgtm again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 ___ cfe-commits mailing list cfe-c

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:218 + if (!D) // global scope. +return getMappingPerLang(L)->NamespaceSymbols->lookup(""); auto It = NamespaceCache.find(D); kadircet wrote: > oh i actually

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 496102. hokein added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang-tools-extra/clangd/unittests/StdLibTests.cpp clang/inc

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:218 + if (!D) // global scope. +return getMappingPerLang(L)->NamespaceSymbols->lookup(""); auto It = NamespaceCache.find(D); oh i actually missed the behav

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibTests.cpp:37 EXPECT_THAT(CXX, HasSubstr("#include ")); - EXPECT_THAT(CXX, Not(HasSubstr("#include "))); + EXPECT_THAT(CXX, HasSubstr("#include ")); kadircet wrote: > hokein

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495910. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang-tools-extra/cl

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibTests.cpp:37 EXPECT_THAT(CXX, HasSubstr("#include ")); - EXPECT_THAT(CXX, Not(HasSubstr("#include "))); + EXPECT_THAT(CXX, HasSubstr("#include ")); hokein wrote: > This is

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibTests.cpp:37 EXPECT_THAT(CXX, HasSubstr("#include ")); - EXPECT_THAT(CXX, Not(HasSubstr("#include "))); + EXPECT_THAT(CXX, HasSubstr("#include ")); This is a behavior change

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495776. hokein added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. fix the clangd unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.l

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495771. hokein added a comment. update the standard-library tests, and fix a bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/include/clang/Tooling/

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495502. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc clang/tools/incl

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495089. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/include/clang/

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang/tools/include-mapping/gen_std.py:123 +c_header = "<" + header[2:-1] + ".h>" +if not any(re.fullmatch(x, symbol.name) for x in exception_symbols): + if symbol.namespace != None: nit: early exits ```

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495056. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/include/clang/

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang/tools/include-mapping/gen_std.py:107-108 symbols = cppreference_parser.GetSymbols(parse_pages) - + # C++ form of the C standard headers. + c_style_headers = { +"", Comment at: clang/

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. Extending the python generator: - to generate C-compatibi