MyDeveloperDay added a comment.
" just to get feedback whether this
option would get accepted or not."
Honestly I can't tell from the code what problem you are trying to fix. The
github issue and unit tests are vital for us to understand what you are trying
to achieve (and to ensure you are not
MyDeveloperDay added a comment.
please point to a github issue which outlines what you are fixing and why
Comment at: clang/lib/Format/Format.cpp:35
#include "clang/Basic/SourceManager.h"
+#include "clang/Format/Format.h"
#include "clang/Lex/Lexer.h"
why movi
MyDeveloperDay added a comment.
Can you please do a full context diff see
(https://llvm.org/docs/Contributing.html)
Comment at: clang/include/clang/Format/Format.h:225
bool AlignCompound;
+// TODO
+bool AcrossParameterDeclarations;
Ok you have to
MyDeveloperDay requested changes to this revision.
MyDeveloperDay added a comment.
This revision now requires changes to proceed.
Please add the unit tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143178/new/
https://reviews.llvm.org/D143178
philbert created this revision.
philbert added reviewers: MyDeveloperDay, owenpan.
Herald added a project: All.
philbert requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I work on a code base that aligns all declarations execpt parameters to
