michaelplatings updated this revision to Diff 499500.
michaelplatings marked 2 inline comments as done.
michaelplatings added a comment.
Rebase and apply changes requested by @peter.smith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143059/new/
ht
michaelplatings updated this revision to Diff 496538.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143059/new/
https://reviews.llvm.org/D143059
Files:
clang/include/clang/Driver/Multilib.h
clang/include
peter.smith added a comment.
A couple of small suggestions but otherwise looks good to me.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:233
+ std::string Result = computeBaseSysRoot(getDriver(), getTriple());
+ if (!SelectedMultilibs.empty()) {
+Result += Selecte
michaelplatings updated this revision to Diff 495558.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143059/new/
https://reviews.llvm.org/D143059
Files:
clang/include/clang/Driver/Multilib.h
clang/include
michaelplatings updated this revision to Diff 495464.
michaelplatings added a comment.
Herald added a subscriber: jobnoorman.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143059/new/
https://reviews.llvm.org/D143059
Files:
clang/include/
michaelplatings updated this revision to Diff 495072.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143059/new/
https://reviews.llvm.org/D143059
Files:
clang/include/clang/Driver/Multilib.h
clang/include
michaelplatings updated this revision to Diff 494416.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143059/new/
https://reviews.llvm.org/D143059
Files:
clang/include/clang/Driver/Multilib.h
clang/include
michaelplatings updated this revision to Diff 494262.
michaelplatings added a comment.
Rebase and change llvm::SmallVector to simply
llvm::SmallVector
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143059/new/
https://reviews.llvm.org/D143059
File
michaelplatings created this revision.
michaelplatings added a reviewer: phosek.
Herald added subscribers: luke, abrachet, frasercrmck, luismarques, apazos,
sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult,
MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD,
