kadircet resigned from this revision.
kadircet added a comment.
Herald added a subscriber: kadircet.
resigning in favor of https://reviews.llvm.org/D153769
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142967/new/
https://reviews.llvm.org/D142967
hokein added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1035
}
+ if (KindAllowed(CodeAction::SOURCE_ORGANIZE_IMPORT)) {
+std::lock_guard Lock(FixItsMutex);
kadircet wrote:
> instead of doing this in here, what about introduc
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1035
}
+ if (KindAllowed(CodeAction::SOURCE_ORGANIZE_IMPORT)) {
+std::lock_guard Lock(FixItsMutex);
instead of doing this in here, what about introducing a new "tweak
hokein updated this revision to Diff 517948.
hokein added a comment.
rebase and polish the implementation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142967/new/
https://reviews.llvm.org/D142967
Files:
clang-tools-extra/clangd/ClangdLSPServer
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This would provide us a way to a
