[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Thank you very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

carlosgalvezp added a comment. Pushed, thanks for the contribution! I took the liberty of fixing the `std::vector` thing before pushing :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

This revision was automatically updated to reflect the committed changes. Closed by commit rGa543d840ee0a: Fix handling of -> calls for modernize-use-emplace (authored by BigPeet, committed by carlosgalvezp). Changed prior to commit: https://reviews.llvm.org/D142939?vs=493756&id=496552#toc Rep

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. > Generally we use prefer `llvm::ArrayRef` over `const std::vector &` I will keep this in mind. Or should this be fixed in this revision? Anyway, if this gets merged, my username/mail are GitHub username: BigPeet GitHub email: pwolf2...@gmail.com Thanks for the fast re

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

njames93 accepted this revision. njames93 added a comment. LGTM Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:93 +// Matches if the node has canonical type matching any of the given names. +auto hasWantedType(const std::vector &TypeNames) { + return h

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

nicovank added a comment. Nevermind, this was fixed as I was looking at it. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list c

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

nicovank added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:100 +auto cxxMemberCallExprOnContainer(StringRef MethodName, + const std::vector ContainerNames) { + return cxxMemberCallExpr( ---

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493756. BigPeet added a comment. - fix passing vector by value instead of by ref-to-const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/c

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Refactored the code a little bit to get rid of some repetitions. Should effectively match the same code as the accepted revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493753. BigPeet added a comment. - additional deduplication of code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/clang-tidy/modernize/Us

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet updated this revision to Diff 493745. BigPeet added a comment. - reducing code repitition + further tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 Files: clang-tools-extra/clang-tidy/mode

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

nicovank accepted this revision. nicovank added a comment. This revision is now accepted and ready to land. This is becoming repetitive, but I guess that's the nature of those things. Maybe something like this would help clean it up, not sure if any better for right now. template // Lambda t

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. BigPeet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes #55869 Repository: rG LLV