Re: [PATCH] D14229: Remove unreachable that was reached in modernize-use-nullptr.

2015-11-02 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 38918. angelgarcia added a comment. Merge lines. http://reviews.llvm.org/D14229 Files: clang-tidy/modernize/UseNullptrCheck.cpp test/clang-tidy/modernize-use-nullptr.cpp Index: test/clang-tidy/modernize-use-nullptr.cpp =

Re: [PATCH] D14229: Remove unreachable that was reached in modernize-use-nullptr.

2015-11-02 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Comment at: test/clang-tidy/modernize-use-nullptr.cpp:191 @@ +190,3 @@ +char function(NoDef *p); +#define F(x) \ +(sizeof(function(x)) == 1) -

[PATCH] D14229: Remove unreachable that was reached in modernize-use-nullptr.

2015-11-02 Thread Angel Garcia via cfe-commits
angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: cfe-commits, klimek. When traversing the parent map, the check assumed that all the nodes would be either Stmt or Decl. After r251101, this is no longer true: there can be TypeLoc and NestedNa