[PATCH] D142174: [OpenMP] Don't set rpath for system paths

2023-03-09 Thread Tom Stellard via Phabricator via cfe-commits
tstellar abandoned this revision. tstellar added a comment. -fopenmp-add-rpath has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142174/new/ https://reviews.llvm.org/D142174 ___ cfe-commits

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

2023-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D142174#4171731 , @JonChesterfield wrote: > I'm happy with this but agree that "what might be a system path?" is a tricky > heuristic. What we want is to exclude the places that the application will > search anyway, but that

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

2023-03-06 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I'm happy with this but agree that "what might be a system path?" is a tricky heuristic. What we want is to exclude the places that the application will search anyway, but th

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

2023-01-19 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:799 +.Default(false); +} + I wasn't sure exactly how to determine if something is a system path, so I'm open to other ideas here. Repository: rG LLVM Github Monorepo

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

2023-01-19 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added reviewers: JonChesterfield, MaskRay. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tstellar requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added