Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-25 Thread Simon Pilgrim via cfe-commits
RKSimon added a subscriber: RKSimon. RKSimon closed this revision. RKSimon added a comment. Committed at http://reviews.llvm.org/rL253886 http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-23 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40933. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c ==

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-20 Thread David Li via cfe-commits
davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. Looks good to me. http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-20 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40794. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c ==

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-20 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40793. sisnkemp added a comment. Added a test with -momit-leaf-frame-pointer as requested by davidxl. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp-1.c test/Code

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-19 Thread David Li via cfe-commits
davidxl added a comment. Can you also add a test case with option -momit-leaf-frame-pointer? http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-16 Thread Sanjay Patel via cfe-commits
spatel added a subscriber: spatel. spatel added reviewers: davidxl, dnovillo, slingn. spatel added a comment. Adding some PGO-active reviewers. http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-15 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 40230. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c ==

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-08 Thread Stefan Kempf via cfe-commits
sisnkemp added a comment. Ping. Can somebody please comment on this? http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-08 Thread Stefan Kempf via cfe-commits
sisnkemp updated this revision to Diff 39651. http://reviews.llvm.org/D14215 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/CodeGen/x86_64-profiling-keep-fp.c Index: test/CodeGen/x86_64-profiling-keep-fp.c ==

[PATCH] D14215: Disable frame pointer elimination when using -pg

2015-11-01 Thread Stefan Kempf via cfe-commits
sisnkemp created this revision. sisnkemp added a subscriber: cfe-commits. When using -pg in combination with optimizations (e.g. -O3), compiled programs crash in the profiling routine mcount(). This is because mcount (on x86_64 at least) relies on the frame pointer to be valid. See test case to