[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

2023-02-06 Thread Kai Nacke via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d93da701b1: [Clang] Fix __ptr32 arguments passed to builtins (authored by Ariel-Burton, committed by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

2023-01-24 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. It sounds to me that the logic from b919c7d should have been restricted to actual LLVM intrinsics that are overloaded on the pointer args ( e.g. llvm.memcpy which was the test in that commit). Builtins that are just library calls with known semantics probably need t

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

2023-01-19 Thread Ariel Burton via Phabricator via cfe-commits
Ariel-Burton updated this revision to Diff 490569. Ariel-Burton added a comment. - Adjust formatting to conform to git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142048/new/ https://reviews.llvm.org/D142048 Files: clang/lib/Sema/

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

2023-01-18 Thread Ariel Burton via Phabricator via cfe-commits
Ariel-Burton created this revision. Herald added subscribers: arichardson, Anastasia. Herald added a project: All. Ariel-Burton requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when clang deals with a call to a builtin function tha