[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5d901feb3c: [Clang] [Sema] Removed a fix-it for system headers (authored by fahadnayyar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:356 ^^^ +- Disabled FIT-IT suggested for a case of bad conversion in system heade

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar marked 3 inline comments as done. fahadnayyar added a comment. In D141868#4060757 , @NoQ wrote: > Looks great! Sounds like you're looking for a more permanent fix, I guess > `ConversionFixItGenerator` could try to avoid adding fixits to syste

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar updated this revision to Diff 490618. fahadnayyar added a comment. Added release notes and changed a normal for-loop to range-based for-loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141868/new/ https://reviews.llvm.org/D141868 Fi

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

aaron.ballman added a comment. You should also add a release note for the changes. Comment at: clang/lib/Sema/SemaOverload.cpp:10920 - // If we can fix the conversion, suggest the FixIts. - for (std::vector::iterator HI = Cand->Fix.Hints.begin(), - HE = Cand->Fix.Hint

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

NoQ added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:10923-10927 +for (std::vector::iterator HI = Cand->Fix.Hints.begin(), + HE = Cand->Fix.Hints.end(); + HI != HE; ++HI) +FDiag << *HI; + } --

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

NoQ added a comment. Looks great! Sounds like you're looking for a more permanent fix, I guess `ConversionFixItGenerator` could try to avoid adding fixits to system header functions? Comment at: clang/lib/Sema/SemaOverload.cpp:10923-10927 +for (std::vector::iterator HI =

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disabled an invalid fix-it which suggested fixes to be applied in system heade