[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5dfec9d444: [Clang][LoongArch] Implement patchable function entry (authored by WANG Xuerui , committed by SixWeining). Changed prior to commit: https://reviews.llvm.org/D141785?vs=49

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785 __

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n updated this revision to Diff 497598. xen0n added a comment. Document the change in Clang release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785 Files: clang/docs/ReleaseNotes.rst clang/i

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n updated this revision to Diff 497596. xen0n added a comment. Rebase and change to lower the op in LoongArchAsmPrinter so as to make people's lives easier when they come to rebase D141785 on top of this. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp:150 + .getAsInteger(10, Num)) +return false; + AP.emitNops(Num); SixWeining wrote: > Seems should return `true`? Consider when verifier is disabl

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

aaron.ballman added a comment. The Clang bits LGTM, though you should add a release note about the new functionality so users know about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785 __

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

SixWeining added a comment. Does anyone know why `patchable-function-entry` is not documented in https://llvm.org/docs/LangRef.html#function-attributes? Comment at: llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp:150 + .getAsInteger(10, Num)) +return fa

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n created this revision. xen0n added reviewers: SixWeining, wangleiat, gonglingqin, MaskRay, xry111. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, hiraditya, arichardson. Herald added a reviewer: aaron.ballman. Herald added a project: All. xen0n requested review of this re