[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd595b59d5c9c: [FPEnv] Fix complex operations in strictfp mode (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 _

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff updated this revision to Diff 491397. sepavloff added a comment. Use --implicit-check-not in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 Files: clang/lib/CodeGen/CGExprComplex.cpp c

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff added a comment. In D141765#4059214 , @kpn wrote: > Are we testing _Complex multiply or subtraction anywhere? I have a vague > memory of multiply not working correctly. There is a test `clang/test/CodeGen/complex-math.c` that checks complex o

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff updated this revision to Diff 490088. sepavloff added a comment. Updated comment in test as proposed by Kevin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 Files: clang/lib/CodeGen/CGExprCom

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

kpn added inline comments. Comment at: clang/test/CodeGen/complex-strictfp.c:8-9 // Include rounding metadata in the testing. -// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. -// FIXME: All cases of "round.tonearest" in this test are wrong. +// All cases of "fp

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

arsenm added inline comments. Comment at: clang/test/CodeGen/complex-strictfp.c:8-9 // Include rounding metadata in the testing. -// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. -// FIXME: All cases of "round.tonearest" in this test are wrong. +// All cases of

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

kpn added a comment. Are we testing _Complex multiply or subtraction anywhere? I have a vague memory of multiply not working correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 ___

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff created this revision. sepavloff added reviewers: rjmccall, kpn, aaron.ballman. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Operations on floating-point complex data had incorrect FP attributes in strictfp mode, because IRBuild