[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Carlos Galvez via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0f5eb3190cfc: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Nathan James via Phabricator via cfe-commits
njames93 accepted this revision. njames93 added a comment. In D141583#4047975 , @carlosgalvezp wrote: > Thanks for reviewing! I can also add that the actual code using the option > was removed around 5 years ago, so it's about time :) @njames93 Do you h

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. Thanks for reviewing! I can also add that the actual code using the option was removed around 5 years ago, so it's about time :) @njames93 Do you have any concerns with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp updated this revision to Diff 488663. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Fix name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D141583 Files: clang-t

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:107 + which is no longer in use. The option will be fully removed in + :program:`clang-tidy-18`. + But isn't such naming artifact of packaging? May be ":program:`clang-tid

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 +- Deprecate the global configuration file option `AnalyzeTemporaryDtors`, + which is no longer in use. The option will be fully removed i

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp updated this revision to Diff 488657. carlosgalvezp added a comment. Update clang-tidy formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D141583 Files: clang-tools-extra/clang-tidy/Clang

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 +- Deprecate the global configuration file option `AnalyzeTemporaryDtors`, + which is no longer in use. The option will be fully removed in clang-tidy 18. + `Clang-tidy

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. If we could get this in before 24th of January (release cut) it would be great, then we don't need to remove it in clang-tidy 19 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

2023-01-12 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It's not used anywhere, and