This revision was automatically updated to reflect the committed changes.
Closed by commit rGcaf393da1823: Fix format for `case` in .proto files
(authored by fowles, committed by krasimir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141547/new/
h
krasimir accepted this revision.
krasimir added a comment.
Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141547/new/
https://reviews.llvm.org/D141547
___
cfe-commits mailing list
cfe-commits@l
fowles updated this revision to Diff 488979.
fowles added a comment.
Move from lit test to unit test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141547/new/
https://reviews.llvm.org/D141547
Files:
clang/lib/Format/UnwrappedLineParser.cpp
cla
krasimir added inline comments.
Comment at: clang/test/Format/case.proto:15
+repeated int32 fizz = 1;
+}
could you please turn this into an unit test here instead >
https://github.com/llvm/llvm-project/blob/main/clang/unittests/Format/FormatTestProto.cpp.
Rep
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141547/new/
https://reviews.llvm.org/D141547
__
fowles created this revision.
fowles added a reviewer: krasimir.
Herald added a project: All.
fowles requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fix format for `case` in .proto files
Repository:
rG LLVM Github Monorepo
https://revi