[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm closed this revision. arsenm added a comment. 00f6a7f02f9c8d542ce8ff1c9c037d9fdb421b88 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141449/new/ https://reviews.llvm.org/D141449 __

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141449/new/ https://reviews.llvm.org/D141449 ___ cfe-commits mailing list cfe-c

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141449/new/ https://reviews.llvm.org/D141449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12428 F->addFnAttr(llvm::Attribute::NoUnwind); + F->addFnAttr(llvm::Attribute::Convergent); yaxunl wrote: > How about using CGF.CGM.addDefaultFunctionDefinitionAttributes? same as be

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12426 // FIXME: Apply default attributes F->addFnAttr(llvm::Attribute::NoUnwind); If `ConstructDefaultFnAttrList` was used it would get convergent correctly... Should we be usi

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12428 F->addFnAttr(llvm::Attribute::NoUnwind); + F->addFnAttr(llvm::Attribute::Convergent); How about using CGF.CGM.addDefaultFunctionDefinitionAttributes? same as below CHANGES SI

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl, jdoerfert. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Yet another example how convergent not being the default