[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-02-24 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. 8709bcacfb3a06847b47bb6b47e8556db43f3a43 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 __

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-02-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Sema/SemaChecking.cpp:17761-17766 + for (int I = 0; I < 3; ++I) { +ExprResult Converted = UsualUnaryConversions(TheCall->getArg

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-02-23 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 499805. arsenm added a comment. Loop merge, documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Builtins.def clang/include/

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-02-23 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2615 QualType ArgTy = TheCall->getArg(0)->getType(); -QualType EltTy = ArgTy; - -if (auto *VecTy = EltTy->getAs()) - EltTy = VecTy->getElementType(

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-01-11 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:634 the most negative integer remains the most negative integer + T __builtin_elementwise_fma(T x, T y, T z) fused multiply add.

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-01-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/lib/Sema/SemaChecking.cpp:2615 QualType ArgTy = TheCall->getArg(0)->getType(); -QualType EltTy = ArgTy; - -if (auto *VecTy = EltTy->getAs()) - EltTy = VecTy->getElement

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-01-04 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2615 QualType ArgTy = TheCall->getArg(0)->getType(); -QualType EltTy = ArgTy; - -if (auto *VecTy = EltTy->getAs()) - EltTy = VecTy->getElementType(); -if (!EltTy->isFloatingType()) { -

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-01-04 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2615 QualType ArgTy = TheCall->getArg(0)->getType(); -QualType EltTy = ArgTy; - -if (auto *VecTy = EltTy->getAs()) - EltTy = VecTy->getElementType(); -if (!EltTy->isFloatingType()) {

[PATCH] D140992: clang: Add __builtin_elementwise_fma

2023-01-04 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added a comment. Need update clang/docs/ReleaseNotes.rst for new intrinsic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/