[PATCH] D140956: [clang-format] Add an option for breaking after C++ attributes

2023-01-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. This LGTM Should we care about other forms of attributes like `__stdcall` etc..? I personally don't, just I assume from the tests this isn't covered (maybe just add that limitation to the doc if it is indeed a limitation) Repository: rG LLVM Github Monorepo

[PATCH] D140956: [clang-format] Add an option for breaking after C++ attributes

2023-01-04 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:324 + /// \c true if this token starts a C++ attribute. + unsigned StartsCppAttribute : 1; + Can be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D140956: [clang-format] Add an option for breaking after C++ attributes

2023-01-04 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch only