[PATCH] D140925: [CMake] Use Clang to infer the target triple

smeenai added inline comments. Comment at: runtimes/CMakeLists.txt:167 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple) ldionne wrote: > Is there any reas

[PATCH] D140925: [CMake] Use Clang to infer the target triple

ldionne accepted this revision. ldionne added inline comments. This revision is now accepted and ready to land. Comment at: runtimes/CMakeLists.txt:167 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_T

[PATCH] D140925: [CMake] Use Clang to infer the target triple

phosek added a comment. SGTM this was previously blocked on other changes, but those all landed so I can go ahead, rebase and land it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140925/new/ https://reviews.llvm.org/D140925 __

[PATCH] D140925: [CMake] Use Clang to infer the target triple

smeenai added a comment. Herald added a subscriber: ekilmer. Herald added a project: libunwind. Herald added a reviewer: libunwind. I think we should land this. Clang has grown workarounds in the meantime, e.g. https://github.com/llvm/llvm-project/blob/4001ae175cbe351d496a6cd5481a554b346f706d/cla

[PATCH] D140925: [CMake] Use Clang to infer the target triple

MaskRay added a comment. In D140925#4151524 , @smeenai wrote: > Ping @ldionne, would you be able to take a look at this soon (or are you okay > waiving the libc++ blocking requirement for it)? This is really useful for > Android armv7, where the triple

[PATCH] D140925: [CMake] Use Clang to infer the target triple

smeenai added a comment. Ping @ldionne, would you be able to take a look at this soon (or are you okay waiving the libc++ blocking requirement for it)? This is really useful for Android armv7, where the triple is traditionally spelled armv7-none-linux-androideabi but normalized to arvm7-none-li

[PATCH] D140925: [CMake] Use Clang to infer the target triple

smeenai accepted this revision. smeenai added a comment. @tamas' suggestion would be a good change to make IMO, but I think it's outside the scope of this patch, and the patch as-is improves the status quo, so LGTM. Is there any way to share the normalization logic between the two locations, or

[PATCH] D140925: [CMake] Use Clang to infer the target triple

tamas added inline comments. Comment at: runtimes/CMakeLists.txt:168 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple) + execute_process(COMMAND ${CXX_TARGET_TRIPLE} ---

[PATCH] D140925: [CMake] Use Clang to infer the target triple

phosek added inline comments. Comment at: runtimes/CMakeLists.txt:168 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple) + execute_process(COMMAND ${CXX_TARGET_TRIPLE} --

[PATCH] D140925: [CMake] Use Clang to infer the target triple

tamas added inline comments. Comment at: runtimes/CMakeLists.txt:168 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple) + execute_process(COMMAND ${CXX_TARGET_TRIPLE} ---

[PATCH] D140925: [CMake] Use Clang to infer the target triple

phosek created this revision. phosek added reviewers: smeenai, ldionne, mstorsjo, mgorny. Herald added subscribers: Enna1, abrachet. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers, libc++, libc++abi. Herald added subscribers: libcxx-c