This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG569222e172e5: [clang][Interp] Only check constructors for
global variables (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.or
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140723/new/
https://reviews.llvm.org/D140723
___
shafik added a comment.
So we are only checking global constructors b/c it is valid in a constant
expression context to initialize a record and not initialize all their fields
as long as we don't use any of those fields.
Note, cases that stem from this has been discussed as part of
https://git
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140723/new/
https://reviews.llvm.org/D140723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140723/new/
https://reviews.llvm.org/D140723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is a follow-up to https://reviews.llvm.org/D13
