royjacobson reopened this revision.
royjacobson added a comment.
This revision is now accepted and ready to land.
So, I had a quick look at this. Turns out this fix changed the argument passing
ABI for those classes on the Sony PS4. This is probably not acceptable :)
Putting this behind an ABI c
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd5dd37ac139a: [Sema] Don't mark deleted special member
functions as non-trivial (authored by royjacobson).
Repository:
rG LLVM Github Monorepo
CH
royjacobson updated this revision to Diff 486347.
royjacobson added a comment.
format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140664/new/
https://reviews.llvm.org/D140664
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaDeclCXX.cpp
royjacobson updated this revision to Diff 486105.
royjacobson edited the summary of this revision.
royjacobson added a comment.
Rebase + remove extra class
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140664/new/
https://reviews.llvm.org/D140664
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Code changes LGTM. Dead CFoo obviously should be used or deleted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140664/new/
https://rev
chriselrod added inline comments.
Comment at: clang/test/SemaCXX/GH59624.cpp:10-12
+struct CFoo{
+const int x{0};
+};
This isn't needed for the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140664/new/
h
royjacobson created this revision.
Herald added a project: All.
royjacobson requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As noted in https://github.com/llvm/llvm-project/issues/59624, we sometimes
mark implicitly
deleted special member
