[PATCH] D140363: Remove incorrectly implemented -mibt-seal

2022-12-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D140363#4014131 , @joaomoreira wrote: > FWIIW, agreed on removing this until we figure out how to make it work > properly. Thanks for the patch @MaskRay. Thanks for accepting the removal:) Repository: rG LLVM Github Mono

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

2022-12-22 Thread Joao Moreira via Phabricator via cfe-commits
joaomoreira added a comment. FWIIW, agreed on removing this until we figure out how to make it work properly. Thanks for the patch @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140363/new/ https://reviews.llvm.org/D140363 __

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

2022-12-22 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG69243cdb926b: Remove incorrectly implemented -mibt-seal (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140363/new/ https://reviews.llv

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

2022-12-22 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. I agree, it's probably best to temporarily revert this until Joao has time to address the issues you mentioned. The Linux kernel doesn't use `-mibt-seal` yet, so dropping the featu

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

2022-12-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: joaomoreira, kees, nickdesaulniers, pcc, samitolvanen, xiangzhangllvm. Herald added subscribers: StephenFan, pengfei, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Heral