[PATCH] D140315: [AMDGCN] Update search path for device libraries

hvdijk added a comment. In D140315#4077611 , @scchan wrote: > In D140315#4076614 , @mgorny wrote: > >> I'm sorry for reporting it this late (clang's been broken for over two >> weeks, so we couldn't periodically

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan added a comment. In D140315#4076614 , @mgorny wrote: > I'm sorry for reporting it this late (clang's been broken for over two weeks, > so we couldn't periodically test it) but this change is causing test > regressions on Gentoo/amd64: Thanks for

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl added inline comments. Comment at: clang/test/Driver/hip-device-libs.hip:206 + +// RESDIR-SAME: "-mlink-builtin-bitcode" "[[DEVICELIB_DIR:[^"]+(/|)rocm_resource_dir(/|)lib(/|)amdgcn(/|).*]]hip.bc" +// ROCMDIR-SAME: "-mlink-builtin-bitcode" "[[DEVICELIB_DI

[PATCH] D140315: [AMDGCN] Update search path for device libraries

mgorny added a comment. In D140315#4077193 , @yaxunl wrote: > @scchan the test expects CLANG_INSTALL_LIBDIR_BASENAME to be `lib`. Maybe in > the failed test it was not true. `CMAKE_INSTALL_LIBDIR=lib64`, so I guess `_BASENAME` is that as well. Reposit

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl added a comment. @scchan the test expects CLANG_INSTALL_LIBDIR_BASENAME to be `lib`. Maybe in the failed test it was not true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 _

[PATCH] D140315: [AMDGCN] Update search path for device libraries

mgorny added a comment. I'm sorry for reporting it this late (clang's been broken for over two weeks, so we couldn't periodically test it) but this change is causing test regressions on Gentoo/amd64: FAIL: Clang :: Driver/hip-device-libs.hip (9304 of 17486) TEST 'Clang

[PATCH] D140315: [AMDGCN] Update search path for device libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa18fe67b9fcf: [AMDGCN] Update search path for device libraries (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://revie

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 __

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan added a comment. In D140315#4011440 , @yaxunl wrote: > files under > clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem > not used. removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan updated this revision to Diff 484945. scchan added a comment. Remove unused bitcode files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/tes

[PATCH] D140315: [AMDGCN] Update search path for device libraries

yaxunl added a comment. files under clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem not used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 __

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan created this revision. scchan added a reviewer: yaxunl. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. - Add support for finding device