This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
li.zhe.hua marked an inline comment as done.
Closed by commit rGa78d4b5ba716: [libTooling] Add flag to getRangeForEdit to
ignore macro expansions (authored by li.zhe.hu
li.zhe.hua marked 2 inline comments as done.
li.zhe.hua added inline comments.
Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:90-92
+ Loc = Expansion.getExpansionLocStart();
+ if (Loc.isFileID())
+return true;
ymandel wrote:
> can you
li.zhe.hua updated this revision to Diff 481506.
li.zhe.hua added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139676/new/
https://reviews.llvm.org/D139676
Files:
clang/include/clang/Tooling/Transformer/SourceCode.h
ymandel accepted this revision.
ymandel added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:90-92
+ Loc = Expansion.getExpansionLocStart();
+ if (Loc.isFileID())
+return true;
-
li.zhe.hua created this revision.
li.zhe.hua added a reviewer: ymandel.
Herald added a project: All.
li.zhe.hua requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This commit resolves the FIXME around the behavior of
`Lexer::makeFileCharRange`
