jrtc27 added inline comments.
Comment at: clang/test/CodeGen/annotations-field.c:5
-// CHECK: private unnamed_addr constant [8 x i8] c"v_ann_{{.}}\00", section
"llvm.metadata"
-// CHECK: private unnamed_addr constant [8 x i8] c"v_ann_{{.}}\00", section
"llvm.metadata"
+// CHE
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
arichardson marked 2 inline comments as done.
Closed by commit rG9114ac67a986: Overload all llvm.annotation intrinsics for
globals argument (authored by arichardson).
arichardson updated this revision to Diff 480900.
arichardson added a comment.
use opaque pointers in the new test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138722/new/
https://reviews.llvm.org/D138722
Files:
clang/lib/CodeGen/CGBuiltin.cpp
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: llvm/test/Bitcode/upgrade-annotation.ll:14
+
+declare i32 @llvm.annotation.i32(i32, i8*, i8*, i32)
+; CHECK: declare i32 @llvm.annotation.i32.p0i8(i32, i8*, i8
arsenm added inline comments.
Comment at: llvm/test/Bitcode/upgrade-annotation.ll:14
+
+declare i32 @llvm.annotation.i32(i32, i8*, i8*, i32)
+; CHECK: declare i32 @llvm.annotation.i32.p0i8(i32, i8*, i8*, i32)
New tests should use opaque pointers. For autoupgrade
arichardson created this revision.
arichardson added reviewers: arsenm, bader, Tyker, nikic.
Herald added subscribers: jrtc27, hiraditya.
Herald added a project: All.
arichardson requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, wdng.
Herald added pr
