This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG13c32288354b: [Clang] Implement LWG3823 for __is_aggregate
(authored by royjacobson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
royjacobson updated this revision to Diff 478495.
royjacobson edited the summary of this revision.
royjacobson added a comment.
rebase to retry CI
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138603/new/
https://reviews.llvm.org/D138603
Files:
royjacobson marked an inline comment as done.
royjacobson added inline comments.
Comment at: clang/test/SemaCXX/type-traits.cpp:556
static_assert(__is_aggregate(EmptyArMB), "");
static_assert(!__is_aggregate(void), "");
static_assert(!__is_aggregate(const volatile void),
cjdb added inline comments.
Comment at: clang/test/SemaCXX/type-traits.cpp:556
static_assert(__is_aggregate(EmptyArMB), "");
static_assert(!__is_aggregate(void), "");
static_assert(!__is_aggregate(const volatile void), "");
shafik wrote:
> Should this be
shafik added inline comments.
Comment at: clang/test/SemaCXX/type-traits.cpp:556
static_assert(__is_aggregate(EmptyArMB), "");
static_assert(!__is_aggregate(void), "");
static_assert(!__is_aggregate(const volatile void), "");
Should this be `true` now or
cjdb accepted this revision.
cjdb added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for fixing this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138603/new/
https://reviews.llvm.org/D138603
__
royjacobson created this revision.
Herald added a project: All.
royjacobson requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
LWG3823 says that arrays of incomplete types are aggregates. Fix the clang
builtin to match that.
Repository:
r
