[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

2023-10-20 Thread Sam McCall via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb99f7e695469: [clangd] Don't run slow clang-tidy checks by default

Re: [PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

2023-10-20 Thread Sam McCall via cfe-commits
Very late, & by email since phab is down. Going to land this based on "LG" comment & offline discussion, happy to do followups if needed. On Mon, Nov 28, 2022 at 10:08 PM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.org> wrote: > kadircet added a comment. > > thanks LG, i'd like to hea

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

2022-11-28 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks LG, i'd like to hear how we're planning to let downstream users customise the list of fast checks. otherwise they have to run with `Loose` at all times. the easiest i can think of is, generating their own `fastchecks.inc` fragment and #include that in addition t

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

2022-11-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 478274. sammccall retitled this revision from "[clangd] Don't run slow clang-tidy checks" to "[clangd] Don't run slow clang-tidy checks by default". sammccall edited the summary of this revision. sammccall added a comment. Add tests of isFast Make isFast a