This revision was automatically updated to reflect the committed changes.
Closed by commit rG5a3d6ce956c4: [Clang][Driver] Add KCFI to SupportsCoverage
(authored by samitolvanen).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138458/new/
https://rev
samitolvanen updated this revision to Diff 477228.
samitolvanen marked 2 inline comments as done.
samitolvanen added a comment.
Switched to `[[#]]`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138458/new/
https://reviews.llvm.org/D138458
Files:
MaskRay added inline comments.
Comment at: clang/test/CodeGen/sanitize-coverage.c:94
+ // CHECK-NOT: call void @__sanitizer_cov_trace_const_cmp
+ // KCFI-NOT: call void %{{.}}() [ "kcfi"(i32 {{.*}}) ]
+ f();
samitolvanen wrote:
> MaskRay wrote:
> > `%c()`
> >
samitolvanen added inline comments.
Comment at: clang/test/CodeGen/sanitize-coverage.c:94
+ // CHECK-NOT: call void @__sanitizer_cov_trace_const_cmp
+ // KCFI-NOT: call void %{{.}}() [ "kcfi"(i32 {{.*}}) ]
+ f();
MaskRay wrote:
> `%c()`
>
> `{{.}}` matches on
samitolvanen updated this revision to Diff 477017.
samitolvanen marked an inline comment as done.
samitolvanen added a comment.
Addressed feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138458/new/
https://reviews.llvm.org/D138458
Files:
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
> with -fsanitize=trace-{pc,cmp}.
`-fsanitize-coverage=` modes such as `trace-{pc,cmp}`.
(a) It's `-fsanitize-coverage=`, not `-fsanitize-coverage=trace-{pc,cmp}`.
(b) ` -fsanitize=trace-{p
samitolvanen created this revision.
Herald added a project: All.
samitolvanen requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Allow -fsanitize=kcfi to be enabled with -fsanitize=trace-{pc,cmp}.
Link: https://github.com/ClangBuiltLi
