[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

2022-11-18 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 closed this revision. jyu2 added a comment. checked with 9d90cf2fca44 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138312/new/ https://reviews.llvm.org/D138312 __

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

2022-11-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138312/new/ https://reviews.llvm.org/D138312 ___

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

2022-11-18 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11048 SeverityClauses.empty() ? nullptr : (*SeverityClauses.begin()); + auto MessageClauses = + OMPExecutableDirective::getClausesOfKind(Clauses); ABataev wrote: > Use real type in

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

2022-11-18 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 476534. jyu2 added a comment. Thanks Alexey for the review. Address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138312/new/ https://reviews.llvm.org/D138312 Files: clang/include/clang/AST/OpenMP

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

2022-11-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11048 SeverityClauses.empty() ? nullptr : (*SeverityClauses.begin()); + auto MessageClauses = + OMPExecutableDirective::getClausesOfKind(Clauses); Use real type instead of auto

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

2022-11-18 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added projects: Flang, All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan