[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a17d059509: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D138296?vs=476473&id=479387#toc Repository:

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I think this is fine. Most of the patch is changing calls to `getTargetAddressSpace` to be internal to IRGen, which, as mentioned, I think is the right move. I do think that if we're goi

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

arichardson added a comment. In D138296#3937599 , @rjmccall wrote: > In D138296#3937486 , @arichardson > wrote: > >> In D138296#3937224 , @eandrews >> wrote: >> >>> Func

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

rjmccall added a comment. In D138296#3937486 , @arichardson wrote: > In D138296#3937224 , @eandrews > wrote: > >> Functionally this looks ok to me. However I am not sure if CodeGenTypes is >> the 'right' place

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

arichardson added a comment. In D138296#3937224 , @eandrews wrote: > Functionally this looks ok to me. However I am not sure if CodeGenTypes is > the 'right' place for this function to live, considering that other functions > with similar functionality

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

eandrews added subscribers: erichkeane, aaron.ballman. eandrews added a comment. Functionally this looks ok to me. However I am not sure if CodeGenTypes is the 'right' place for this function to live, considering that other functions with similar functionality are in ASTContext - including overl

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

arichardson updated this revision to Diff 476473. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138296/new/ https://reviews.llvm.org/D138296 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

arichardson created this revision. arichardson added reviewers: eandrews, dylanmckay, bader, rjmccall. Herald added subscribers: jrtc27, luismarques, s.egerton, Jim, PkmX, atanasyan, simoncook, kristof.beyls, sdardis. Herald added a project: All. arichardson requested review of this revision. Hera