[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc414bbefe45a: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 479693. hctim added a comment. Lots of places in scudo_standalone depend on GWP-ASan, and it seems far more reasonable to make COMPILER_RT_HAS_GWP_ASAN mean "is GWP-ASan actually going to be built", rather than checking three variables in all the places. Give

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. Thanks for the detailed information folks. I'll probably fix it up and re-submit next week (after the US holidays) given that the blast radius seems to be bigger than I expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hans added a comment. Reverted in 907baeec49bfbe9e76498634a9418e1dc6c973d9 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 ___ cfe-commits mailing list

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hans added a comment. Chromium is broken too CMake Error at /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/cmake/modules/AddLLVM.cmake:1915 (add_dependencies): The dependency target "ScudoUnitTests" of target "check-runtimes" does not exist. Call Stack (most recent call first):

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

DavidSpickett added a comment. We (Linaro) also have an issue with a bot that uses `-DCOMPILER_RT_BUILD_SANITIZERS=OFF`. https://lab.llvm.org/buildbot/#/builders/178/builds/3318 CMake Error at cmake/modules/AddLLVM.cmake:1915 (add_dependencies): The dependency target "ScudoUnitTests" of t

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

smeenai added a comment. We're seeing a CMake error after this: CMake Error at /data/users/smeenai/Source/tcdev/external/llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:368 (add_library): Error evaluating generator expression: $ Objects of target "RTGwpAsan.x86_

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab1a5991fe76: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. In D138157#3935173 , @phosek wrote: > Is the plan to eventually rename `scudo_standalone` to `scudo` once the > santiizer-based Scudo implementation is deleted? Ideally, yes (as well as make scudo_standalone not be in a subfolder)

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

phosek added a comment. Is the plan to eventually rename `scudo_standalone` to `scudo` once the santiizer-based Scudo implementation is deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 __

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added inline comments. Comment at: llvm/docs/GwpAsan.rst:174 ++-++ -| PerfectlyRightAlign| false | When allocations are right-aligned, should we

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 476241. hctim marked 2 inline comments as done. hctim added a comment. Remove unrelated diff from doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 Files: clang/li

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/GwpAsan.rst:174 ++-++

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, abrachet, phosek, cryptoad. Herald added a project: All. hctim requested review of this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, MaskRay. Herald added projects: clang,