[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da41fe69622: [cmake] Fix _GNU_SOURCE being added unconditionally (authored by Trass3r, committed by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. `Andreas Hollandt ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. In D137917#3925161 , @Trass3r wrote: > Thanks could you also commit it? Sure, what name and email should I use for you when committing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. Thanks could you also commit it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. I only came across it when testing a PCH build. https://github.com/Trass3r/llvm-project/actions/runs/3423679621/jobs/5702548183 Warning: (1,9): warning: definition of macro '_GNU_SOURCE' does not match definition in precompiled header [-Wclang-cl-pch] It was set for c

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. I think this looks OK. What kind of errors were you seeing before this fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-c

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added inline comments. Comment at: clang/CMakeLists.txt:417 -add_definitions( -D_GNU_SOURCE ) - Found when building with clang-cl. It's already handled correctly in the llvm config file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r created this revision. Herald added a project: All. Trass3r requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137917 Files: clang/CMakeLists.txt l