This revision was automatically updated to reflect the committed changes.
Closed by commit rG9332ddfba69c: [Clang] Extend the number of case
Sema::CheckForIntOverflow covers (authored by shafik).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D137897?vs=475528&
shafik updated this revision to Diff 475528.
shafik added a comment.
Add Release note.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137897/new/
https://reviews.llvm.org/D137897
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/integer-overflow.cp
shafik added a comment.
It looks like `conditional_callbacks.c` has been failing every once and while
before this change. I can't seem to track down when it started yet.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137897/new/
https://reviews.llvm.org/D137897
shafik updated this revision to Diff 474981.
shafik added a comment.
Fix formatting of test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137897/new/
https://reviews.llvm.org/D137897
Files:
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/integer-overflow.cpp
Index: clang/test/Sem
shafik created this revision.
shafik added reviewers: aaron.ballman, erichkeane.
Herald added a project: All.
shafik requested review of this revision.
Currently `Sema::CheckForIntOverflow` misses several case that other compilers
diagnose for overflow in integral constant expressions. This inclu