This revision was automatically updated to reflect the committed changes.
Closed by commit rG8fa2e9353859: [clang] Do not merge traps in functions
annotated optnone (authored by hnrklssn).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137714/new/
ht
delcypher accepted this revision.
delcypher added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137714/new/
https://reviews.llvm.org/D137714
___
cfe-commits mailing list
cfe-commits@lists
hnrklssn updated this revision to Diff 475104.
hnrklssn marked an inline comment as done.
hnrklssn added a comment.
Add explicit labels to FileCheck checks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137714/new/
https://reviews.llvm.org/D137714
delcypher added a comment.
Other than minor issue in the test this LGTM
Comment at: clang/test/CodeGen/ubsan-trap-debugloc.c:11
+void bar(volatile int a) __attribute__((optnone)) {
+ // CHECK: call void @llvm.ubsantrap(i8 0){{.*}} !dbg [[LOC2:![0-9]+]]
+ // CHECK: call void @
hnrklssn marked 2 inline comments as done.
hnrklssn added a comment.
Made changes in line with what @fcloutier suggested.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5321
+ SetLLVMFunctionAttributesForDefinition(D, Fn);
CodeGenFunction(*this).GenerateCode(GD, Fn, FI);
hnrklssn updated this revision to Diff 474811.
hnrklssn added a comment.
No longer reorders annotations to occur before codegen. Instead EmitTrapCheck
checks the function declaration for OptimizeNoneAttr.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
fcloutier requested changes to this revision.
fcloutier added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5321
+ SetLLVMFunctionAttributesForDefinition(D, Fn);
CodeGenFunction(*this).GenerateCode(GD, Fn, FI
hnrklssn created this revision.
Herald added a project: All.
delcypher added a comment.
hnrklssn updated this revision to Diff 474504.
hnrklssn added reviewers: delcypher, rapidsna, fcloutier, t.p.northover,
patrykstefanski.
hnrklssn published this revision for review.
Herald added a project: clan
