[PATCH] D137650: [clangd] Implement hover for string literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG92297bde5ce1: [clangd] Implement hover for string literals (authored by v1nh1shungry, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D137650: [clangd] Implement hover for string literals

tom-anders added a comment. In D137650#3919089 , @kadircet wrote: > sure i am happy to land, @tom-anders do you have anything else to add ? LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/

[PATCH] D137650: [clangd] Implement hover for string literals

kadircet added a comment. sure i am happy to land, @tom-anders do you have anything else to add ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commit

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry added a comment. @kadircet Could you please help me commit it? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commits mailin

[PATCH] D137650: [clangd] Implement hover for string literals

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 __

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474466. v1nh1shungry added a comment. Modify the name in the hover info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.c

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry added a comment. @kadircet Thanks for your suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474399. v1nh1shungry added a comment. Apply the reviewing suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D137650: [clangd] Implement hover for string literals

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:816 + if (llvm::isa(E)) { +HoverInfo::PrintedType PT; +PT.Type = E->getType().getAsString(PP); can you extract this into a function, similar to the cases below?

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474179. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp clang-tools