[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee2056e7: [Clang] Correctly capture bindings in dependent lambdas. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming precommit CI doesn't discover any problems from the latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 487464. cor3ntin added a comment. Symplify printing a NamedDecl in moved code per Aaron's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/incl

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:125 +diag::err_param_default_argument_references_local) + << D->getDeclName() << DefaultArg->getSourceRange(); } aaron.ballman wrote: > aaron.ballman wro

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:125 +diag::err_param_default_argument_references_local) + << D->getDeclName() << DefaultArg->getSourceRange(); } aaron.ballman wrote: > `ValueDecl`

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

rymiel added inline comments. Comment at: clang/test/SemaCXX/cxx20-decomposition.cpp:160 +return a; +}() ; }(0); +(void)[&](auto c) { return b + [&a](auto) { aaron.ballman wrote: > Same edit elsewhere. Did clang-format get confused? It can't be cl

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 487453. cor3ntin added a comment. Rewrite assert in DeclCXX.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/include/clang/AST/Decl.h clang/inclu

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:3232 +VarDecl *ValueDecl::getPotentiallyDecomposedVarDecl() { + assert((isa(this) || isa(this)) && + "expected a VarDecl or a BindingDecl"); aaron.ballman wrote: > cor3ntin wrote: > >

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 487452. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/include/clang/AST/Decl.h clang/include/cl

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:3232 +VarDecl *ValueDecl::getPotentiallyDecomposedVarDecl() { + assert((isa(this) || isa(this)) && + "expected a VarDecl or a BindingDecl"); cor3ntin wrote: > aaron.ballman wrote:

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:3232 +VarDecl *ValueDecl::getPotentiallyDecomposedVarDecl() { + assert((isa(this) || isa(this)) && + "expected a VarDecl or a BindingDecl"); aaron.ballman wrote: > That's future tech,

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman added a comment. Mostly just nits from me at this point. Comment at: clang/lib/AST/DeclCXX.cpp:3232 +VarDecl *ValueDecl::getPotentiallyDecomposedVarDecl() { + assert((isa(this) || isa(this)) && + "expected a VarDecl or a BindingDecl");

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added a comment. @aaron.ballman gentle ping. I hope your feedback was addressed to your satisfaction :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 __

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

shafik added a comment. This looks reasonable to me but not confident enough to approve it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 ___ cfe-commits mail

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 474770. cor3ntin added a comment. Address Shafik's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/include/clang/AST/Decl.h clang/include/cl

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18251-18252 + SemaRef.tryCaptureVariable(V, Loc, Sema::TryCapture_Implicit, + /*EllipsisLoc*/ SourceLocation(), + /*BuildAndDiagnose*/ true, CaptureType,

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 474080. cor3ntin marked 4 inline comments as done. cor3ntin added a comment. Address Aaron's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:3234-3237 + if (auto *Var = llvm::dyn_cast(this)) +return Var; + if (auto *BD = llvm::dyn_cast(this)) +return llvm::dyn_cast(BD->getDecomposedDecl()); aaron.ballman wrote: > No need t

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added a comment. In D137244#3915633 , @aaron.ballman wrote: > Thanks for this! Can you also add a release note for the changes? Thanks for the Review! As mentioned this fixes an unreleased feature, hence why I don't think a release note entry

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman added a comment. Thanks for this! Can you also add a release note for the changes? Comment at: clang/include/clang/AST/Decl.h:673 +class VarDecl; + This should be moved up to around line 77 or so (and kept in alphabetical order).

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 472920. cor3ntin added a comment. Use the `getPotentiallyDecomposedVarDecl` everywhere it makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added a comment. (No changelog, this fixes an unreleased feature) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 ___ cfe-commits mailing list cfe-comm

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 472581. cor3ntin added a comment. Forgot to clang-format! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang/include/clang/AST/Decl.h clang/include/cla

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Structured bindings were not properly marked odr-used and therefore captured