[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7348bb36c557: [clang][Interp] Support inc/dec operators for pointers (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D137

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing lis

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:216 - static_assert(getNextElem(E, 1) == 3); -#endif + static_assert(getNextElem(E, 1) == 3, ""); + aaron.ballman wrote: > aaron.ballman wrote: > > I'd like test cases where the point

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder updated this revision to Diff 474724. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opco

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:216 - static_assert(getNextElem(E, 1) == 3); -#endif + static_assert(getNextElem(E, 1) == 3, ""); + aaron.ballman wrote: > I'd like test cases where the pointer arithmetic has r

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:421-425 +// [Pointer] -> [] +def IncPtr : Opcode { + let HasGroup = 0; +} +// [Pointer] -> [] aaron.ballman wrote: > Don't both of these result in a `Pointer`? And should they have a `Typ

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder updated this revision to Diff 474182. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opco

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:421-425 +// [Pointer] -> [] +def IncPtr : Opcode { + let HasGroup = 0; +} +// [Pointer] -> [] Don't both of these result in a `Pointer`? And should they have a `Types` field?

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder updated this revision to Diff 472526. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td clang/test/AST/Interp/arrays.cpp

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think this is pretty uncommon so I was trying to